Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does gRPC-go URL encode /'s from xDS dial target #7002

Closed
arvindbr8 opened this issue Feb 26, 2024 · 1 comment
Closed

Does gRPC-go URL encode /'s from xDS dial target #7002

arvindbr8 opened this issue Feb 26, 2024 · 1 comment
Assignees

Comments

@arvindbr8
Copy link
Member

This PR to gRFC A47 - xDS Federation , raised a question on how gRPC-go does URL encoding of /'s. It seems like we do URL encoding of the path "excluding the slashes" intentionally here.

The expected behavior is that we URL encode everything (including the /'s) from the URI path.

This issue is to track this investigation. We need to add a test case, if we don't have one.

@arvindbr8
Copy link
Member Author

Ever since fc0aa46 we have been encoding gRPC Dial targets (/ inclusive).

xDS targets uses the default behavior which is to encode the path component here. https://github.com/grpc/grpc-go/blame/master/clientconn.go#L1871

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant