Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting HTTPS proxy without setting HTTPS_PROXY env variable #7358

Closed
jskiba opened this issue Jun 27, 2024 · 2 comments · Fixed by #7361
Closed

Setting HTTPS proxy without setting HTTPS_PROXY env variable #7358

jskiba opened this issue Jun 27, 2024 · 2 comments · Fixed by #7361
Assignees
@jskiba
Labels
Type: Documentation Documentation or examples

Comments

@jskiba
Copy link

jskiba commented Jun 27, 2024

https://github.com/grpc/grpc-go/blob/master/Documentation/proxy.md#custom-proxy - this page seems to be out of date since WithDialer option is deprecated. Is there any other alternative to this?
@purnesh42H purnesh42H self-assigned this Jun 28, 2024
@purnesh42H
Copy link
Contributor

@jskiba I will take a look and get back to you

@purnesh42H
Copy link
Contributor

purnesh42H commented Jun 28, 2024 •
edited
Loading

@jskiba WithDialer is deprecated. You can use WithContextDialer instead. Will update the documentation

@purnesh42H purnesh42H assigned jskiba and unassigned purnesh42H Jun 28, 2024
@purnesh42H purnesh42H mentioned this issue Jun 28, 2024
Merged
@purnesh42H purnesh42H added the Type: Documentation Documentation or examples label Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jskiba jskiba

Labels
Type: Documentation Documentation or examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

documentation: Update proxy docs to point to WithContextDialer purnesh42H/grpc-go
3 participants
@purnesh42H @dfawley @jskiba