Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source code and compiled class is inconsistent #10224

Open
98DE9E1F opened this issue May 26, 2023 · 1 comment
Open

source code and compiled class is inconsistent #10224

98DE9E1F opened this issue May 26, 2023 · 1 comment
Milestone

Comments

@98DE9E1F
Copy link

What version of gRPC-Java are you using?

1.55.1

What is your environment?

mac open jdk 11

What did you expect to see?

in source code type variable is T extends AbstractManagedChannelImplBuilder

public abstract class AbstractManagedChannelImplBuilder
    <T extends AbstractManagedChannelImplBuilder<T>> extends ManagedChannelBuilder<T> 

What did you see instead?

when i decompile class , i found the type variable change to

public abstract class AbstractManagedChannelImplBuilder
  <T extends ManagedChannelBuilder<T>> extends ManagedChannelBuilder<T> {

Steps to reproduce the bug

just compare source.jar and jar in release 1.55.1

@ejona86
Copy link
Member

ejona86 commented May 26, 2023

This is because of a ".class file hack" mentioned in the v1.36.0 release notes. I have been wanting us to remove it, as enough time has passed and it impacts the build in a weird way, but we've been busy doing other things. The goal is to make the source code look like the decompiled code you showed, re-doing what we attempted in v1.33.0 (which was reverted in v1.33.1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants