Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decompression occurring in Transport thread #18

Closed
ejona86 opened this issue Jan 20, 2015 · 1 comment
Closed

Decompression occurring in Transport thread #18

ejona86 opened this issue Jan 20, 2015 · 1 comment
Assignees
@nmittler
Labels
enhancement

Comments

@ejona86
Copy link
Member

ejona86 commented Jan 20, 2015

Apparently we are decompressing in the transport thread just so that we are able to provide the correct byte length to messageRead(). It seems we should remove the length argument to messageRead(), use Buffers.openStream(nextFrame, true), pass that stream to messageRead() (instead of calling toByteArray), and then set nextFrame = null.
@nmittler nmittler self-assigned this Jan 27, 2015
@nmittler
Copy link
Member

This is addressed by #45

@nmittler nmittler mentioned this issue Jan 29, 2015
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Sep 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nmittler nmittler

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ejona86 @nmittler