Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plan upgrade to OkHttp 3? #2999

Closed
b95505017 opened this issue May 12, 2017 · 3 comments
Closed

Any plan upgrade to OkHttp 3? #2999

b95505017 opened this issue May 12, 2017 · 3 comments

Comments

@b95505017
Copy link

As title.

@ejona86
Copy link
Member

ejona86 commented May 12, 2017

We didn't really. We've manually "shaded" most of OkHttp that we use such that the okhttp dependency is just for our surface API for specifying TLS settings (via ConnectionSpec).

We could probably have OkHttpChannelBuilder support both ConnectionSpec from OkHttp 2 and 3 simultaneously. It would mean depending on both versions, but when using ProGuard only one would be used.

It's not clear whether that just gives us a "nice feeling" or whether it actually would benefit someone.

@ejona86
Copy link
Member

ejona86 commented Jun 20, 2017

It doesn't sound like this provides a tangible benefit, so closing. It'd be easy to convince me otherwise, though. So if this would benefit you, say so and we will consider it. Also mention whether depending on both OkHttp 2 and OkHttp 3 would be a solution for you.

@ejona86 ejona86 closed this as completed Jun 20, 2017
@kraghu
Copy link

kraghu commented Jul 21, 2017

In Android We are so used to okhttp for handling all our rest call needs . It will benefit us from learning point of view.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants