Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have grpc-protobuf-lite depend on protobuf-javalite, not protobuf-lite #6405

Closed
bubenheimer opened this issue Nov 7, 2019 · 3 comments · Fixed by #6424
Closed

Have grpc-protobuf-lite depend on protobuf-javalite, not protobuf-lite #6405

bubenheimer opened this issue Nov 7, 2019 · 3 comments · Fixed by #6424
Assignees
Milestone

Comments

@bubenheimer
Copy link

bubenheimer commented Nov 7, 2019

What version of gRPC-Java are you using?

1.25.0, 1.24.2

What did you expect to see?

My understanding is that with more recent protobuf versions the Java Lite code generation requires a different approach and is compatible with com.google.protobuf:protobuf-javalite artifacts as opposed to the old com.google.protobuf:protobuf-lite:3.0.1 artifacts. The current grpc-protobuf-lite still depends on the old com.google.protobuf:protobuf-lite:3.0.1, yet the current grpc artifacts generally use recent protobuf versions. I expected to see a dependency on the new protobuf-javalite artifact instead. Or would a new grpc-protobuf-javalite artifact be more appropriate?

@ejona86
Copy link
Member

ejona86 commented Nov 9, 2019

This is more a question of when will grpc upgrade to depend on the newer javalite version. Already if using javalite you need to make sure your protoc (plugin) version matches the .jar version; 3.9 generated code is not guaranteed compatible with 3.10 runtime. It is true today that you need to exclude the protobuf-javalite dependency if using a newer version, but grpc-protobuf-lite itself is okay with either dependency.

I've been watching javalite to determine an appropriate time to bump the version. I've spoken to protobuf team about its current state as well. I got really close to swapping for 3.10, but I was waiting for some issues to be ironed out. For example, I was expecting some documentation to resolve protocolbuffers/protobuf#6565. I was mainly wanting to avoid pushing people to the new version while it was a rocky road.

But it'd be really easy to update the version when things are ready.

@ejona86 ejona86 added enhancement and removed bug labels Nov 9, 2019
@ejona86 ejona86 added this to the Next milestone Nov 9, 2019
@bubenheimer
Copy link
Author

Thank you for the explanation and additional pointers, I had been doubtful that excluding the dependency would suffice. I successfully went to grpc 1.25.0 from 1.21.0 in my builds now after the long-standing blocker #6217 was resolved.

@ejona86
Copy link
Member

ejona86 commented Nov 13, 2019

Based on protocolbuffers/protobuf#6867, it seems protocolbuffers/protobuf#6565 is no longer an issue, although the issue is still open. We could upgrade.

@ejona86 ejona86 modified the milestones: Next, 1.26 Nov 14, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants