Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netty: Delete AttributeKey.newInstance("channelLogger") #7062

Closed
ejona86 opened this issue May 26, 2020 · 0 comments · Fixed by #7933
Closed

netty: Delete AttributeKey.newInstance("channelLogger") #7062

ejona86 opened this issue May 26, 2020 · 0 comments · Fixed by #7933
Labels
code health
Milestone
1.37

Comments

@ejona86
Copy link
Member

ejona86 commented May 26, 2020

As I mentioned in #6707 (comment) :

But even better: we should consider deleting the attribute. It is only used by ProtocolNegotiators, which already has access to GrpcHttp2ConnectionHandler. We could just add method to GrpcHttp2ConnectionHandler instead, which would be explicit.

#6707 is closed because the issue itself is resolved. But this is to clean things up more.
@ejona86 ejona86 added this to the Next milestone May 26, 2020
@YifeiZhuang YifeiZhuang mentioned this issue Mar 2, 2021
Merged
@ejona86 ejona86 modified the milestones: Next, 1.37 Mar 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
code health
Projects
None yet
Milestone
1.37
Development

Successfully merging a pull request may close this issue.

core: Move negotiationLogger from channel attributes to handler YifeiZhuang/grpc-java
1 participant
@ejona86