Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup ManagedChannelImpl shutdown/shutdownNow flow #7410

Open
dapengzhang0 opened this issue Sep 10, 2020 · 0 comments
Open

Cleanup ManagedChannelImpl shutdown/shutdownNow flow #7410

dapengzhang0 opened this issue Sep 10, 2020 · 0 comments
Labels
code health
Milestone
Next

Comments

@dapengzhang0
Copy link
Member

The implementation of ManagedChannelImpl shutdown/shutdownNow flow evolved into a mess after a sequence of features being added, typically the retry (ManagedChannelImpl.uncommittedRetriableStreamRegistry) and ConfigSelector (ManagedChannelImpl.pendingCalls). This needs some cleanup.
@dapengzhang0 dapengzhang0 added this to the Next milestone Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code health
Projects
None yet
Milestone
Next
Development

No branches or pull requests
1 participant
@dapengzhang0