Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to compile s2a.proto #150

Closed
pkwarren opened this issue Apr 30, 2024 · 2 comments
Closed

Unable to compile s2a.proto #150

pkwarren opened this issue Apr 30, 2024 · 2 comments

Comments

@pkwarren
Copy link

pkwarren commented Apr 30, 2024

The newly added s2a proto files from #149 fail to compile with protoc 26.1 with the following error message:

grpc/gcp/s2a/s2a.proto:306:3: "s2a.proto.Identity" is resolved to "grpc.gcp.s2a.proto.Identity", which is not defined. The innermost scope is searched first in name resolution. Consider using a leading '.'(i.e., ".s2a.proto.Identity") to start from the outermost scope.

I believe the fix is:

--- a/grpc/gcp/s2a/s2a.proto
+++ b/grpc/gcp/s2a/s2a.proto
@@ -303,7 +303,7 @@ message SessionReq {
   // identity is not populated, S2A will try to deduce the managed identity to
   // use from the SNI extension. If that also fails, S2A uses the default
   // identity (if one exists).
-  s2a.proto.Identity local_identity = 1;
+  Identity local_identity = 1;
 
   // The authentication mechanisms that the application wishes to use to
   // authenticate to S2A, ordered by preference. S2A will always use the first
@ejona86
Copy link
Member

ejona86 commented Apr 30, 2024

@rmehta19

Looks like this wasn't noticed in the PR because the PR didn't add any Bazel targets.

@pkwarren
Copy link
Author

Thanks for fixing - I can verify things look good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants