Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Different services in the same proto file cannot have the same rpc/method name. grpc-web common js import #346

Closed
weilip1803 opened this issue Oct 29, 2018 · 0 comments · Fixed by #362
Closed

[Bug] Different services in the same proto file cannot have the same rpc/method name. grpc-web common js import #346

weilip1803 opened this issue Oct 29, 2018 · 0 comments · Fixed by #362

Comments

@weilip1803
Copy link

weilip1803 commented Oct 29, 2018 •
edited
Loading

It generates the multiple of your const methodInfo_${your_same_rpc_method_name} which causes it fail to compile
@weilip1803 weilip1803 changed the title [Bug] Different services in the same proto file cannot have the same method name [Bug] Different services in the same proto file cannot have the same method name. grpc-web common js import Oct 29, 2018
@weilip1803 weilip1803 changed the title [Bug] Different services in the same proto file cannot have the same method name. grpc-web common js import [Bug] Different services in the same proto file cannot have the same rpc/method name. grpc-web common js import Oct 29, 2018
@weilip1803 weilip1803 mentioned this issue Nov 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the method name clashes for generated commonjs files
1 participant
@weilip1803