Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ascii art positioning #183

Open
hertg opened this issue Nov 1, 2021 · 7 comments
Open

ascii art positioning #183

hertg opened this issue Nov 1, 2021 · 7 comments
Labels
area/ascii Has something to do with ASCII art. type/feature Request a new feature.

Comments

@hertg
Copy link

hertg commented Nov 1, 2021

I've glanced over the theme documentation and I don't think there's this possibility yet.

Add a setting to specify the position where the ascii art should be displayed. Currently, it always displays on the left.
I have a fairly wide but short ascii art I'd like to use, it would look best if it was above the system info box.
Having a wide ascii art side by side with the system info doesn't work well in narrow terminal windows.

Something like:

[custom_ascii]
# Possible values: top, right, bottom, left
# Default value: left
position = "top"
@grtcdr
Copy link
Member

grtcdr commented Nov 1, 2021

This is interesting, we could definitely do this :)

@hertg
Copy link
Author

hertg commented Nov 1, 2021

Just had an afterthought about that feature-request, so I'll just leave that here as a brain-dump, it may be a bit overkill (?)

Additionally to the positioning, specifying the alignment could also be pretty cool. Alignment could for example be an enum of: Start, Center, or End.

[custom_ascii]
# Possible values: start, center, end
# Default value: start
alignment = "center"

Example for what I mean:

       alignment: start                alignment: center               alignment: end
  _______  __________________              __________________              __________________
  |     |  |                |              |                |              |                |
  | img |  |                |     _______  |                |              |                |
  |_____|  |                |     |     |  |                |              |                |
           |      text      |     | img |  |      text      |     _______  |      text      |
           |                |     |_____|  |                |     |     |  |                |
           |                |              |                |     | img |  |                |
           |________________|              |________________|     |_____|  |________________|

If the textbox is larger than the ascii image, then the alignment could be applied to the box instead.

@grtcdr
Copy link
Member

grtcdr commented Nov 2, 2021

@123marvin123 How feasible would this be with the current structure?

@123marvin123
Copy link
Member

@123marvin123 How feasible would this be with the current structure?

It shouldn't be too hard, I think, but some things would need to be refactored to allow such a placement. Right now, we are using the ASCII art on the left side of the screen as an anchor to align the actual readout information.

I am currently too busy to work on this, maybe you can give it a try?

@grtcdr
Copy link
Member

grtcdr commented Nov 2, 2021

I am currently too busy to work on this, maybe you can give it a try?

Totally, just needed to know how big of a task this would be.

@grtcdr grtcdr added type/feature Request a new feature. area/ascii Has something to do with ASCII art. and removed enhancement labels Nov 16, 2021
@shajra
Copy link

shajra commented Dec 22, 2021

Can we please make this feature also include a way to disable the image as well? I like the information, but don't need the image, which also don't render well on my light-themed terminal.

@grtcdr
Copy link
Member

grtcdr commented Dec 22, 2021

If you're looking to disable ASCII art, just set hide_ascii = true in your theme.

@grtcdr grtcdr changed the title [FEATURE] ascii art positioning ascii art positioning May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ascii Has something to do with ASCII art. type/feature Request a new feature.
Development

No branches or pull requests

4 participants