Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6: breaking changes in themes, bug fixes and new features. #200

Merged
merged 90 commits into from
Dec 13, 2021
Merged

v6: breaking changes in themes, bug fixes and new features. #200

merged 90 commits into from
Dec 13, 2021

Conversation

grtcdr
Copy link
Member

@grtcdr grtcdr commented Nov 7, 2021

v6 codename "Gallium" — CHANGELOG

We hope this is the last time we have to break your themes and configs, but hopefully you won't be so annoyed thanks to the new changes and features that this new version brings. Go on, have a read:

Breaking Changes

  • MACCHINA_CONF has been deprecated, please use --config from now on, you can alias macchina to macchina --config <PATH> to avoid typing it every time.

  • hide_bar_delimiters has been deprecated, but the feature isn't gone. You can hide your bar's delimiters using hide_delimiters, here's what'd look like:

[bar]
hide_delimiters = true
  • palette has been deprecated, and again, the feature is still here. But, you now have to specify the type of variant you'd like to display and what glyph to use:
[palette]
type = "Full"
glyph = ""
visible = true

Bugfixes

  • We've officially demoted DESKTOP_SESSION, preferring XDG_CURRENT_DESKTOP over it. DESKTOP_SESSION is essentially a fallback now. (closes [BUG] DE info for KDE Plasma #199)
  • --short-uptime has been renamed to --long-uptime. Somehow, I forgot to rename the long version of this command-line flag, and you can verify this by comparing the flag name with the flag description — they contradict each other.
  • The spacing bug, that results in an uneven space between the left side and right side of the separator, has been fixed.

New features

  • Every single option in a theme is now optional, feel free to remove anything you don't need!
  • You can specify the kind of border you want macchina to use, under [box], you can add:
# Accepted values: "plain", "rounded" and "thick".
border = "plain"
  • You can now tell macchina what pool of color to use when randomization is enabled, under [randomize], you can add:
# Accepted values: "base", "hexadecimal" and "indexed"
pool = "base"
[palette]
glyph = ""
  • Added manpages — Woohoo!
    • There's one for the configuration file, and another for theming.
  • More datapaths to look at:
  • We've brought back the ability to toggle between showing your physical/logical core count.

Miscellaneous

  • When using --list-themes, themes are now listed below the directory that contains them, resulting in much cleaner output.
  • Some under-the-hood changes you might not notice, which mostly address the complexity of certain operations (hopefully improving performance).
  • Psst... Gentoo users, macchina doesn't require portage-utils anymore.

What's new?

- You can now specify what kind of borders to use through box.border,
  which can take one of the four values: "double", "plain", "thick",
  "rounded" — casing? insensitive.

- hide_box_delimiters has been moved to box.hide_delimiters [BREAKING
  CHANGE]

- box.title is now optional, it can be omitted from your configuration
in case you don't use it.

v6 will likely contain more features than this the day of its release.
restyled-io bot and others added 3 commits November 7, 2021 04:44
Co-authored-by: Restyled.io <commits@restyled.io>
Harness the power of Asciidoctor!
rename: screenshots -> assets
move: ascii -> contrib/ascii
restyled-io bot and others added 7 commits November 7, 2021 06:32
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Restyled.io <commits@restyled.io>
@grtcdr
Copy link
Member Author

grtcdr commented Dec 5, 2021

Also currently it gives two errors if the theme is not found so that needs to be fixed. Should be an easy fix I guess.

@uttarayan21 Fixed with a959c0a

I've also bumped the Rust edition to 2021.

@0323pin
Copy link

0323pin commented Dec 5, 2021

@grtcdr Running v6.0.0 built from the latest commit now, all good. Thanks!

https://i.postimg.cc/mgcyZQMc/2021-12-05-204750-1366x768-scrot.png

@grtcdr
Copy link
Member Author

grtcdr commented Dec 5, 2021

Quite a clean theme you got there, would you mind adding it to contrib/themes?

There's only so many elements in the periodic table, so we should probably start using a sensible naming scheme.

@0323pin
Copy link

0323pin commented Dec 5, 2021

Sure, I'll make a PR later.

@0323pin
Copy link

0323pin commented Dec 5, 2021

@grtcdr
Copy link
Member Author

grtcdr commented Dec 5, 2021

@grtcdr or, if you don't want to wait curl it from here, https://codeberg.org/pin/leftwm-netbsd/raw/branch/main/home/.config/macchina/themes/Oxide.toml

No I don't mind waiting. If you merge a PR you get your name on the contributors list, which is always nice :)

@0323pin
Copy link

0323pin commented Dec 5, 2021

@grtcdr or, if you don't want to wait curl it from here, https://codeberg.org/pin/leftwm-netbsd/raw/branch/main/home/.config/macchina/themes/Oxide.toml

No I don't mind waiting. If you merge a PR you get your name on the contributors list, which is always nice :)

Done :smile

@grtcdr
Copy link
Member Author

grtcdr commented Dec 8, 2021

@uttarayan21 The way we handle MACCHINA_CONF does not comply with the way macchina searches for themes, I think it's better to rewrite it from scratch.

@uttarayan21
Copy link
Member

Isn't MACCHINA_CONF only for the config file ?

@grtcdr
Copy link
Member Author

grtcdr commented Dec 8, 2021

Isn't MACCHINA_CONF only for the config file ?

Yeah, but that's not enough to source the themes. If macchina can't find its config in predefined locations, it also won't find its themes.

@grtcdr grtcdr mentioned this pull request Dec 9, 2021
- removed:
  - MACCHINA_CONF handling
- refactored:
  - main
- reworked:
  - config handling
as well as making the effort to keep main.rs tiny with the necessary
functions in separate modules.
What spacing bug?

It's a weird bug that can appear when you have only a *few* readouts showing,
you'll notice the spacing between the separator and the content besides
it is *uneven*.
@grtcdr
Copy link
Member Author

grtcdr commented Dec 13, 2021

I've fixed the spacing bug, v6 will release soon ❤️ (no ETA yet)

@grtcdr grtcdr merged commit d49a54a into main Dec 13, 2021
@grtcdr grtcdr deleted the v6 branch December 13, 2021 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[FEATURE] Support system-wide installation [BUG] DE info for KDE Plasma
3 participants