Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculated trade amounts omit fees #344

Open
badgerwithagun opened this issue Apr 28, 2019 · 0 comments
Open

Calculated trade amounts omit fees #344

badgerwithagun opened this issue Apr 28, 2019 · 0 comments
Assignees
Labels
bug Something isn't working java Requires Java skills urgent XChange Requires changes to XChange library
Projects

Comments

@badgerwithagun
Copy link
Member

Some exchanges (tested: CBP, Bitmex) add fees to the buy side on buys and sell side on sells, rather than reducing the amount bought (as with BFX) so if you calculate a trade amount based on balance and target amount, there will be insufficient balance.

Needs fixing to take account of the fees on exchanges with this model. Probably means adding some metadata to XChange to tell us which type of exchange is involved.

@badgerwithagun badgerwithagun added bug Something isn't working java Requires Java skills XChange Requires changes to XChange library labels Apr 28, 2019
@badgerwithagun badgerwithagun self-assigned this Apr 28, 2019
@badgerwithagun badgerwithagun added this to To do in v1.0.0 via automation Apr 28, 2019
@badgerwithagun badgerwithagun moved this from To do to In progress in v1.0.0 Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working java Requires Java skills urgent XChange Requires changes to XChange library
Projects
v1.0.0
  
In progress
Development

No branches or pull requests

1 participant