Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condition Looks odd.. #117

Closed
dazinator opened this issue Aug 21, 2017 · 2 comments
Closed

Condition Looks odd.. #117

dazinator opened this issue Aug 21, 2017 · 2 comments

Comments

@dazinator
Copy link

#if (!NETFX_CORE && !PORTABLE && !NETSTANDARD1_0 && !NETSTANDARD1_1 && !NETSTANDARD1_2 && !NETSTANDARD1_3 && !NETSTANDARD1_4 && !NETSTANDARD1_5 || !NETSTANDARD1_6)

Just wondering - If I have grasped the intent of the code correctly, should that last bit on the line above not be && !NETSTANDARD1_6 or perhaps || NETSTANDARD1_6 ?

@dazinator
Copy link
Author

The reason I say that is because at the moment this is resulting in a duplicate type being incuded when targeting net45 and netstandard1.6

@niemyjski
Copy link
Collaborator

Yeah, we'll have to update this for the other net standards as well. We probably need to do a poll and see what versions we still need to support and support only that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants