Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.min.js is not minified #7

Closed
st-schneider opened this issue Oct 29, 2018 · 1 comment
Closed

.min.js is not minified #7

st-schneider opened this issue Oct 29, 2018 · 1 comment

Comments

@st-schneider
Copy link

the .min.js in dist is not minified.
gruns added a commit that referenced this issue Oct 29, 2018
@gruns
Only build iron-db.min.js with npm run build, not npm run dev (ak…
bbd8598 
…a `webpack --mode production`). Otherwise, `npm run build` clobbers `iron-db.min.js` with an unminified version. Prevents the recurrence of #7.
@gruns
Copy link
Owner

gruns commented Oct 29, 2018 •
edited

Wonderful catch.

iron-db.min.js was unwittingly clobbered by npm run dev. I pushed bbd8598 to
avoid the recurrence of this situation in the future.

Thank you for bringing this issue to my attention @bm-stschneider. Don't
hesitate to let me know if there's anything else I can do for you.

@gruns gruns closed this as completed Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gruns @st-schneider