concat process.title instead of overwrite

[stevenvachon]

I posted an identical issue to this one for npm.

---

process.title = "grunt";

overwrites the original title (of "Command Prompt", etc) thereby stripping away our ability to detect which shell is being used on Windows during tests.

process.title += " - grunt";

as node produces (in Windows), would be better.

[sindresorhus]

👎 That's the point of process.title to be able to clearly show what's currently running. Using that for detecting the type of terminal is fragile as any module or sub-dependency can overwrite it. Find another way. This is not a concern of grunt or npm. There's also a max length of process.title which makes this even more unfeasible.

[stevenvachon]

Any dependency other than npm/grunt/gulp/etc changing the title is an automatic "don't do that". I did not know about the max length, though, which does pose a problem.

There're only two other solutions:

1. a native Windows binding to grab the original process/window title
2. have the Node.js team add a process.env.SHELL or similar for Windows, containing the original process/window title (since the location of the shell executable requires admin)

[vladikoff]

That's the point of process.title to be able to clearly show what's currently running.

Agreed. pretty sure a lot of modules set process.title. As well as a lot of tools are built around relying on the process title.