Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for compatibility with grunt 0.4.0rc5 #11

Closed
cowboy opened this issue Jan 9, 2013 · 3 comments
Closed

Update for compatibility with grunt 0.4.0rc5 #11

cowboy opened this issue Jan 9, 2013 · 3 comments

Comments

@cowboy
Copy link
Member

cowboy commented Jan 9, 2013

I need someone to help update this plugin to work with grunt 0.4.0rc5.

I had to revert the whole file src-dest mappings implicit iteration abstraction per gruntjs/grunt#606, and once again, multi tasks have to iterate over this.files manually. In addition, there's a new this.filesSrc array that contains a reduced, uniqued set of all matched src files in case the task is read-only and only cares about source files.

See:

Notes:

  • A user may specify a new option nonull in addition to src to tell grunt to keep patterns or filepaths that don't actually match files. Because of this, the task shouldn't explode if a nonexistent src filepath is encountered. I handle this in the grunt-contrib-concat by warning if not grunt.file.exists but not failing the task.

Guidelines for updating / publishing this plugin:

  • Change this project's version number to one ending in "rc5" so that it's clearer that it works with grunt 0.4.0rc5. If the existing version number doesn't end in an "a" or "rc" increment the patch version. Eg, jshint went from 0.1.0 -> 0.1.1rc5
  • Ensure grunt 0.4.0rc5-compatible plugins are specified in package.json devDependencies like this (grunt-contrib-internal can be "*")
  • Update the CHANGELOG like this
  • Regenerate the README.md file via grunt.
  • Delete node_modules, run npm cache clean and re-run npm install to test.
  • Publish to npm using --tag=master (not latest)
@shama
Copy link
Member

shama commented Jan 10, 2013

Done on 58be8df. Just needs a publish.

@mattd
Copy link

mattd commented Jan 13, 2013

+1 on the publish. :)

@tkellen
Copy link
Member

tkellen commented Jan 23, 2013

0.5.0rc7 is on npm now. The 'wrapped' option is now defaulted to true, which matches the handlebars binary. Thanks a million for the cleanup on this Shama!

@tkellen tkellen closed this as completed Jan 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants