Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more UI without --verbose? #249

Closed
JamesMGreene opened this issue Aug 21, 2014 · 10 comments
Closed

No more UI without --verbose? #249

JamesMGreene opened this issue Aug 21, 2014 · 10 comments

Comments

@JamesMGreene
Copy link

PR #229 reduced verbosity by so much than a normal use of this plugin no longer produces any UI feedback unless the --verbose flag is set. This is confusing and doesn't offer any worthwhile benefit that I can see.

Running normally:

Running "uglify:dist" (uglify) task

Running with --verbose:

Running "uglify" task

Running "uglify:dist" (uglify) task
Verifying property uglify.dist exists in config...OK
Files: dist/document.currentScript.js -> dist/document.currentScript.min.js
Options: banner="", footer="", compress={"warnings":false}, mangle={}, beautify=false, report="min", expression=false, preserveComments="some"
Minifying with UglifyJS...Reading dist/document.currentScript.js...OK
OK
Writing dist/document.currentScript.min.js...OK
File dist/document.currentScript.min.js created: 4.93 kB → 2.06 kB

Mac OS X Mavericks (10.9), Node v0.10.28, grunt-cli@0.1.13, grunt@0.4.5, grunt-contrib-uglify@0.5.1

@UltCombo
Copy link
Contributor

Isn't there any guideline for verbosity in grunt-contrib plugins? Creating one would avoid all these discussions.

Anyway, I believe most users want feedback when files are written to disk, so .log is more suitable here imho.

//cc @sindresorhus

@sindresorhus
Copy link
Member

I'm done discussing this on a myriad a plugins time and time again. Please bring this up on the main grunt issue tracker so there can be something coherent among the contrib plugins ;)

Fwiw, the opinion on verbose or minimal by default is like 50-50.

@vladikoff
Copy link
Member

@sindresorhus yeap 100% agree with your comment. One thing we need to fix though is to show how many files created:

This is a bit ugly right now:
image

Reopening until we fix that.

@vladikoff vladikoff reopened this Aug 21, 2014
@sindresorhus
Copy link
Member

I also feel like we have a lot of duplicated code in plugins. We use grunt.file.write. Why can't the file count be shown automatically or with a simple method. More guidelines and DRYing would be nice.

@vladikoff
Copy link
Member

Output fixed in 0.6.0

@JamesMGreene
Copy link
Author

Thanks, @vladikoff! ❤️

@davegreenwp
Copy link

I've just upgraded to 0.6.0 and I'm still only getting 'X files created': is this an ongoing problem? I just want to see the size change in the output :/

Cheers,
Dave

@JamesMGreene
Copy link
Author

@davetgreen: Before this fix, you wouldn't have even saw "X files created" but yes, it would be nice to also get the size outputs back in there like they used to be, especially since there is a config option controlling that which is essentially being ignored. 😲

@joaovieira
Copy link

👍 what @JamesMGreene said: having the reports back would be nice.

@prionkor
Copy link

+1 The compression report should be shown like cssMin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants