Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security: force UglifyJS to be at version 2.4.24 minimum #350

Closed
mgol opened this issue Aug 24, 2015 · 3 comments
Closed

Security: force UglifyJS to be at version 2.4.24 minimum #350

mgol opened this issue Aug 24, 2015 · 3 comments

Comments

@mgol
Copy link
Contributor

mgol commented Aug 24, 2015

The article at https://zyan.scripts.mit.edu/blog/backdooring-js/ explains how one can leverage a bug in UglifyJS 2.4.23 and earlier (not sure when it was introduced) to introduce security issues that manifest only in minified code.

Now, anyone that today does npm install on a project using the latest grunt-contrib-uglify will get the patched 2.4.24 version but people that already have an older one installed will keep it. It would be good to publish a patch that changes the uglify-js version range from ^2.4.19 to ^2.4.24.
@UltCombo
Copy link
Contributor

👍

@vladikoff
Copy link
Member

Fixed! Thanks!

@vladikoff vladikoff mentioned this issue Aug 24, 2015
Merged
@mgol
Copy link
Contributor Author

mgol commented Aug 24, 2015

Thanks!

@JamesMGreene JamesMGreene mentioned this issue Aug 25, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vladikoff @mgol @UltCombo