Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong 'sourceMappingURL' prefix #58

Closed
aar0nr opened this issue May 23, 2013 · 8 comments
Closed

Wrong 'sourceMappingURL' prefix #58

aar0nr opened this issue May 23, 2013 · 8 comments

Comments

@aar0nr
Copy link

aar0nr commented May 23, 2013

The sourceMappingURL prefix is currently "//#" as shown on the following line:

https://github.com/gruntjs/grunt-contrib-uglify/blob/master/tasks/lib/uglify.js#L83

However, this doesn't work in Chrome (v27.0.1453.93). Chrome expects "//@", which is also referenced in the UglifyJS2 docs:

--source-map-url   The path to the source map to be added in //@ sourceMappingURL.  Defaults to the value passed with --source-map.
@jsoverson
Copy link
Member

This has been changed in UglifyJS2 here although may be a bit premature given the state of the tracked issues in firefox and chrome

@mishoo, what was your timeline to publish the next version after UglifyJS2/213 was merged?

@mishoo
Copy link

mishoo commented May 23, 2013

@jsoverson Published v2.3.6 containing the change.

@aar0nr
Copy link
Author

aar0nr commented May 23, 2013

Ah I see. Thanks for the heads up.

@jsoverson
Copy link
Member

@mishoo, didn't mean to rush you, was just wondering if you knew more about the status of the support in browsers.

@mattrobenolt, @acdha, any input as the creators of the respective PRs?

@acdha
Copy link
Contributor

acdha commented May 23, 2013

@jsoverson No clean fixes: it probably makes sense to hold off on shipping the patch until browser support ships and remove it after it's been in for a release or two.

@mattrobenolt
Copy link

@jsoverson I was following along the discussions about the spec, and it changed a few weeks ago. All of the browser vendors are on the same page with updating, but I suppose only time will tell as to when they adopt.

jQuery is going this direction, just not yet either. See: http://bugs.jquery.com/ticket/13793#comment:12

@jsoverson
Copy link
Member

Reverted these changes and published 0.2.2 until ff/chrome gain support. Will open an issue but please feel free to ping on it if anyone is actively monitoring those browser issues.

@jamie-pate
Copy link

Why not include both? they are /comments/ right?
in chrome Version 27.0.1453.93 (linux) //# is not working for me

(i'm pretty confused about this whole thing...
reverting to grunt-cli@0.1.8 uglify-js@2.3.5 and grunt-contrib-uglify@0.2.0 seems to fix it for me)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants