Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break grunt.log out into grunt-legacy-log #1130

Closed
cowboy opened this issue May 1, 2014 · 9 comments
Closed

Break grunt.log out into grunt-legacy-log #1130

cowboy opened this issue May 1, 2014 · 9 comments
Milestone

Comments

@cowboy
Copy link
Member

cowboy commented May 1, 2014

See:
https://github.com/gruntjs/grunt/tree/legacy-log
https://github.com/gruntjs/grunt-legacy-log

@tkellen will this do what you need for logging in grunt-next?

@vladikoff @jmeas please test this branch of Grunt to ensure I didn't break any logging in your projects, etc.

@tkellen
Copy link
Member

tkellen commented May 1, 2014

Woot!

@jamesplease
Copy link
Member

I tried this out on a project that used a bunch of grunt-contrib plugins and it worked just fine. I'd be curious to see how it behaves on some non-contrib plugins!

@cowboy
Copy link
Member Author

cowboy commented May 2, 2014

Yeah, I'd love a little more testing before I pull it into master.

@vladikoff
Copy link
Member

🚢 🇮🇹

@tkellen
Copy link
Member

tkellen commented May 2, 2014

I tried this on a bunch of projects last night and everything seems great.

@tkellen
Copy link
Member

tkellen commented May 2, 2014

But I do not use many non-contrib plugins, so my testing probably hasn't gone any further than James's has.

@tkellen
Copy link
Member

tkellen commented May 2, 2014

Just ran a few more tests, I can't see anything wrong on this end.

@vladikoff vladikoff modified the milestones: 0.4.6, 0.4.5 May 6, 2014
@vladikoff
Copy link
Member

Fixed in 0149291 👍

@tkellen
Copy link
Member

tkellen commented May 6, 2014

Woot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants