Update os.sh #28
Update os.sh #28
Conversation
WSL detection support.
|
@chadbrewbaker looks okay to me. I don't run Windows or WSL but I wanted to check if they publish a |
| @@ -36,6 +36,10 @@ function os_is_redhat { | |||
| grep -q "Red Hat Enterprise Linux Server release $version" /etc/*release | |||
| } | |||
|
|
|||
| # Returns true (0) if this is a WSL kernel or false (1) otherwise. | |||
| function os_is_wsl_kernel { | |||
| [[ $(uname -r | tail -c19) == "microsoft-standard" ]] | |||
There was a problem hiding this comment.
How stable / reliable is looking at column 19? Could that change in a future release?
There was a problem hiding this comment.
This does seem brittle... Maybe use grep instead?
There was a problem hiding this comment.
Bash supports regex, no need to grep, /etc/os-release would be Ubuntu/Redhat etc, whatever WSL2 container the user has loaded. It's a config string in their build, https://github.com/microsoft/WSL2-Linux-Kernel/blob/master/Microsoft/config-wsl#L22
I used tail instead of head so the version number length is variable.
|
@chadbrewbaker thanks for your contribution. Unfortunately we’ve fallen behind on PRs and are removing old PRs. If this change is still required, we encourage you to re-open. |
WSL detection support.