Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for setting securytcontext for a container #26

Closed
tverhoeven opened this issue Jul 17, 2019 · 3 comments
Closed

Allow for setting securytcontext for a container #26

tverhoeven opened this issue Jul 17, 2019 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tverhoeven
Copy link

tverhoeven commented Jul 17, 2019

We are using the k8s-service chart with great succes. But we recently stumbled on a issue. One of the container images that we need to deploy needs to run in privileged mode.

This means that we need to be able to set:
securityContext:
privileged: true
in the deployment record.

But currently the chart does not allow you to specifiy this or any other securityContext settings. Could this be added to the chart?

Thanks, Tim

@yorinasub17 yorinasub17 added enhancement New feature or request good first issue Good for newcomers help wanted labels Jul 17, 2019
@yorinasub17
Copy link
Contributor

That's a good idea to add! We are pretty buried right now so might not get to this in the short term. Would you be up for a PR?

@shenal
Copy link

shenal commented Sep 3, 2019

This feature has been implemented and released in v0.0.7
@yorinasub17 , @tverhoeven , @autero1 We can close this out

@autero1
Copy link
Contributor

autero1 commented Sep 3, 2019

Closing, implemented in #36

@autero1 autero1 closed this as completed Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants