Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress TLS block does not match the spec #34

Closed
shenal opened this issue Aug 26, 2019 · 1 comment
Closed

Ingress TLS block does not match the spec #34

shenal opened this issue Aug 26, 2019 · 1 comment

Comments

@shenal
Copy link

shenal commented Aug 26, 2019

Ingress TLS block does not match the k8s Ingress spec and fails on deploy

Example values:

ingress:
  enabled: true
  path: /
  hosts:
    - test-app.com
  servicePort: 80
  tls:
    - secretName: test-app-tls
      hosts:
      - test-app.com

Incorrectly rendered template

# Source: k8s-service/templates/ingress.yaml
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: release-name-test-app
  labels:
    gruntwork.io/app-name: test-app
    # These labels are required by helm. You can read more about required labels in the chart best
practices guide:
    # https://docs.helm.sh/chart_best_practices/#standard-labels
    app.kubernetes.io/name: test-app
    helm.sh/chart: k8s-service-0.0.1-replace
    app.kubernetes.io/instance: release-name
    app.kubernetes.io/managed-by: Tiller
spec:
  tls:
    hosts:
    - test-app.com
    secretName: test-app-tls

  rules:
    - host: "test-app.com"
      http:
        paths:
          - path: /
            backend:
              serviceName: release-name-test-app
              servicePort: 80
@shenal
Copy link
Author

shenal commented Sep 3, 2019

This issue has been fixed in the v0.0.7 Release

@shenal shenal closed this as completed Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant