Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for flexible environment variable settings #59

Closed
yorinasub17 opened this issue Jan 24, 2020 · 3 comments
Closed

Add support for flexible environment variable settings #59

yorinasub17 opened this issue Jan 24, 2020 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@yorinasub17
Copy link
Contributor

e.g being able to specify:

    spec:
      containers:
      - image: foobar:latest
        name: go-test-monitor-container
        imagePullPolicy: Always
        env:
          - name: DD_AGENT_HOST
            valueFrom:
              fieldRef:
                fieldPath: status.hostIP
          - name: DD_ENTITY_ID
            valueFrom:
              fieldRef:
                fieldPath: metadata.uid 
@yorinasub17 yorinasub17 added enhancement New feature or request good first issue Good for newcomers help wanted labels Jan 24, 2020
@yorinasub17
Copy link
Contributor Author

Suggested implementation is to expose an input value called additional_container_env which can be used to pass in raw list items that are rendered for the env map.

@jjneely
Copy link
Contributor

jjneely commented Jan 28, 2020

Implementation: #60

@yorinasub17
Copy link
Contributor Author

This is now released as v0.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants