Add list-remove module #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brikis98
approved these changes
Apr 19, 2019
| # b) distinct will discard duplicate items in the order they are found | ||
| # => If you slice the new list from the point of the length of the first list in the concat, then you will get the | ||
| # second list of concat with all the elements from the first list removed. | ||
| # Inspired by https://github.com/hashicorp/terraform/issues/16044#issuecomment-392269246 |
modules/list-remove/README.md
Outdated
| @@ -0,0 +1,27 @@ | |||
| # List Remove Module | |||
|
|
|||
| This is a module that can be used to remove items in a given list from another list. | |||
There was a problem hiding this comment.
You might want to mention this is not yet built into Terraform's interpolation functions
| terraform.InitAndApply(t, terratestOptions) | ||
|
|
||
| assertOutputEquals(t, "output_list_as_csv", "us-east-1a,us-east-1d,us-east-1e", terratestOptions) | ||
| } |
There was a problem hiding this comment.
You may want to make the inputs to that example configurable and run through a few more test cases:
- Two empty lists
- One filled list, one empty
- Two identical lists
- Two lists with no overlap
|
UPDATE 8798f61 :
Will merge and cut release if the build passes. |
|
Ok build passed. Merging. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a
list-removemodule, which can be used to do list subtraction. In other words, this is a module to be able to remove specific items from a list in terraform.Note: This was inspired from a conversation with a customer in slack.