Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for snapshot testing #1377

Closed
jguionnet opened this issue Nov 30, 2023 · 2 comments · Fixed by #1378
Closed

Add support for snapshot testing #1377

jguionnet opened this issue Nov 30, 2023 · 2 comments · Fixed by #1378
Labels
enhancement New feature or request

Comments

@jguionnet
Copy link
Contributor

Describe the solution you'd like
helm-unittest as a great feature called snapshot testing.

Sometimes you may just want to check that the rendered manifest did not change between helm package version without every details asserted.

Describe alternatives you've considered
None and neither did the community, see https://github.com/orgs/gruntwork-io/discussions/780

Additional context

@Mo0rBy
Copy link

Mo0rBy commented Dec 6, 2023

Hello, I just came across this issue simply because it was fresh and at the top of the page.
For context, please read this article. I believe this is how Camunda test their own Helm charts. It describes "Golden template files" and I think these are essentially snapshots.

Could be what you are looking for, or could be used for inspiration to add snapshots to this already great tool.

@jguionnet
Copy link
Contributor Author

@Mo0rBy Thanks for the reference. The linked pull request (#1378) implements it for helm install, which does not have the TS and other generated ID issues. I feel it is better than the implementation from Camunda as it provides a diff git like which show all the difference, see the gist referenced in the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants