Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http_helper package is covering HTTP GET methods only and doesn't allow to send HTTP Headers #186

Closed
sw-samuraj opened this issue Oct 26, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@sw-samuraj
Copy link

The http_helper package currently supports the HTTP GET method only. Additionally, it doesn't allow to send any HTTP Header.

Questions:

  1. Is it planned to support other HTTP methods, e.g. POST?

  2. Is it planned to support HTTP Headers? This could be important if a service expects some mandatory headers, e.g. a token etc.

@brikis98 brikis98 added enhancement New feature or request help wanted labels Oct 27, 2018
@brikis98
Copy link
Member

We add methods when we use them. So far, most of our tests have needed GET and no headers, but if you have a use case that needs more, I'd definitely welcome a PR to add those!

@robmorgan
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants