fix(tetris): move 2 lines down #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #117 |
|
@alocquet Indeed .. thanks . I actually don't remember why I did this, I certainly took a wrong path when implementing this. Any refacto to make the code cleaner is more than welcome ! |
alocquet
force-pushed
the
fix/tetris-move-two-lines-down
branch
from
64dc65a
to
a6f27d6
Compare
alocquet
force-pushed
the
fix/tetris-move-two-lines-down
branch
from
a6f27d6
to
32d3ca5
Compare
|
I have renames some variables. Let me know if you think it is more readable. |
|
Yeah perfect. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't understand why do you remove index to line : if a block is on a line upper than removed line, it should move down. This is independent of removed line index in 'lines2' array.
I have tested with 2 and 3 lines removed and it work.
If you are ok with that, I can also refactor this code to rename variables like
lines2.