Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript support #33

Closed
jenglamlow opened this issue Oct 29, 2018 · 4 comments
Closed

Typescript support #33

jenglamlow opened this issue Oct 29, 2018 · 4 comments

Comments

@jenglamlow
Copy link

Hi,

Is there any plan to support Typescript by providing declaration file? I have check "@types/subtitle" is not exist yet in NPM yet
@gsantiago
Copy link
Owner

I'm open for contributions

@jenglamlow
Copy link
Author

I have created a definition file and create PR to DefinitelyTyped repo. It is successfully merged DefinitelyTyped/DefinitelyTyped@e33c890

You should get to download the definition file at @types/subtitle soon

@gsantiago
Copy link
Owner

Where do I get this file? Do I need to commit it or publish it on npm?

@jenglamlow
Copy link
Author

Hi,

You can get the file at here

I'm closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gsantiago @jenglamlow