Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TOML 1.0 #3

Closed
apirogov opened this issue May 11, 2023 · 2 comments
Closed

Support TOML 1.0 #3

apirogov opened this issue May 11, 2023 · 2 comments

Comments

@apirogov
Copy link

This is valid TOML, but your toml-lint website says it isn't:

[tool.poetry]
name = "dummy-project"
version = "0.1.0"
description = ""
authors = ["John Doe <j.doe@example.com>"]
readme = "README.md"
packages = [{include = "dummy_project"}]

include = [
  # having both a string and an object here seems to trigger the problem:
  "CHANGELOG.md",
  { path = "tests", format = "sdist" },
  # ----
]

[tool.poetry.dependencies]
python = "^3.8"
pyproject-parser = "^0.8.0"
tomli = "^2.0.1"


[build-system]
requires = ["poetry-core"]
build-backend = "poetry.core.masonry.api"

Your site comes quite at the top when searching for "check TOML", and it was e.g. used to quickly dismiss an issue.

Would be nice if you update it to support TOML 1.0, as being the first TOML checker tool google presents makes you somewhat of an "authority".

If this is too much work, maybe at least state for which TOML spec version your site is.

Thanks!

@gscho
Copy link
Owner

gscho commented May 12, 2023

@apirogov the site has the spec version listed in the top left hand corner.

I do plan to update the parsing library to support spec v1.0. Unfortunately the current library this site uses will need to be swapped out completely for another since it is never going to support toml v1.0

@gscho gscho mentioned this issue May 14, 2023
@gscho
Copy link
Owner

gscho commented May 14, 2023

Closed by #4

@gscho gscho closed this as completed May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants