Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure in 0.2.6 #12

Closed
maximbaz opened this issue Jan 24, 2022 · 5 comments
Closed

Test failure in 0.2.6 #12

maximbaz opened this issue Jan 24, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@maximbaz
Copy link
Contributor

Hi there,

I'm running tests as part of AUR package, and it shows one failed test, which I can also reproduce manually 馃槈

It's mostly FYI, plus a suggestion to perhaps use Github Actions to run tests on main branch?

If you want, this works really well for my other rust project:

name: CI
on:
  push:
    branches: [main]
  pull_request:
    branches: [main]

jobs:
  test:
    name: test
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - run: cargo test --locked

  lint:
    name: lint
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - run: cargo fmt -- --check
      - run: cargo clippy -- -Dwarnings
@maximbaz maximbaz added the bug Something isn't working label Jan 24, 2022
@TheBestTvarynka
Copy link
Contributor

I'll deal with it tonight

@Gskartwii
Copy link
Owner

Hi, thanks for the heads-up! I made a mistake when updating the specification of the test case, and I've now fixed it in v0.2.7. I'll be sure to add in the automated testing Action as soon as possible. Do let me know if there are any further issues with this release.

@maximbaz
Copy link
Contributor Author

Thanks! There is an issue of Cargo.lock being not up-to-date with Cargo.toml (it still shows 0.2.6 for example), so building the project with --locked flag (to make sure it uses dependency versions exactly as you wanted them to be) is failing. I think if you just do cargo build or any command, it will update it 馃憤

@maximbaz
Copy link
Contributor Author

I made a PR for you to play with, you can see how it fails now and how after updating Cargo.lock it should hopefully succeed: #13

@Gskartwii
Copy link
Owner

Okay, I hope third time's the charm! For the sake of not overwriting Git tag history, I've created yet another release v0.2.8. 馃槄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants