Header covers table view while cell is animating

[Jackson0111]

Hi! Great work! I noticed something weird and haven't quite figured out a solution yet. I subclassed GSKStretchyHeaderView and added it to my table view. Everything works great but the header always covers table view cells during cell's animation (to be more specific, this is the table view animation I'm using: https://github.com/Ramotion/folding-cell). This only happens when header's height is smaller than its max height(aka, when scrolled up). It looks like this issue #5 but I'm not sure what exactly is causing this problem. Any ideas?

[gskbyte]

Hi!

Well, this seems to actually be the opposite: in order to fix the issue #5 I implemented a fix to make the stretchy header stay always on top, probably disabling this might fix your issue. I will have to think of a better way to implement it or just make it configurable.

If you want to try it, just comment out the code to keep the stretchy header on top and if it works for you, you can even make a PR. I will have a look this weekend, or if I have time earlier this week.

Best regards

[Jackson0111]

Not sure which part of the code I should block. Any clue? I will keep working on it, meanwhile, please let me know when you have some thoughts!

[gskbyte]

Hi, this is the code responsible for that: https://github.com/gskbyte/GSKStretchyHeaderView/blob/master/Pod/Classes/GSKStretchyHeaderView.m#L139 I will try to have a look this afternoon :)

[Jackson0111]

Just tried blocking that but didn't work. I can post my code and some screenshots if you'd like to see it, or you can add a header to https://github.com/Ramotion/folding-cell and see where the issue is. Let me know.

[Jackson0111]

Also, you mentioned in another issue that the pull to refresh is already implemented. Can you point me to which function/block/property that performs this?

[gskbyte]

Hi,

I just tested it with the folding cell example app and everything seems to work, without touching any code

I just added this to MainTableViewController.swift:

        let headerView = GSKStretchyHeaderView(frame: CGRectMake(0, 0, 320, 320))
        headerView.contentView.backgroundColor = UIColor.orangeColor()
        headerView.minimumContentHeight = 64
        self.tableView.addSubview(headerView)

Best regards

[gskbyte]

I've implemented a new method to keep the header view on top of the table view, I hope it works better, although it seemed to work with the older implementation. I'm closing this issue for now.

[Jackson0111]

Still couldn't figure out what I might've done wrong, but thanks! I will try the new method.