Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"rustls" feature now depends on "native-tls" #75

Closed
davegallant opened this issue Oct 25, 2020 · 2 comments
Closed

"rustls" feature now depends on "native-tls" #75

davegallant opened this issue Oct 25, 2020 · 2 comments

Comments

@davegallant
Copy link

davegallant commented Oct 25, 2020

0.11.3 did not have a dependency on "openssl":

[dependencies]
sendgrid = { version = "0.11.3", features = ["rustls"] }
cargo tree -i -p native-tls
error: package ID specification `native-tls` matched no packages

Now with 0.13.0:

[dependencies]
sendgrid = { version = "0.13.0", features = ["rustls"] }

There is a dependency upon "native-tls":

cargo tree -i -p native-tls
native-tls v0.2.4
├── hyper-tls v0.4.3
│   └── reqwest v0.10.8
│       └── sendgrid v0.13.0
│           └── sendgrid-rs-issue v0.1.0 (/tmp/rust-sendgrid)
├── reqwest v0.10.8 (*)
└── tokio-tls v0.3.1
    ├── hyper-tls v0.4.3 (*)
    └── reqwest v0.10.8 (*)

It is no longer possible to cross-compile sendgrid-rs to x86_64-unknown-linux-musl.

@gsquire
Copy link
Owner

gsquire commented Oct 25, 2020

Alright so I looked at the history of the cargo manifest file and it looks to me like native-tls was added as a default feature post version 0.11. Did you compile with the --no-default-features flag by chance?

With that being said, these two features shouldn't be getting mixed up. I'll have to adjust that.

@davegallant
Copy link
Author

Alright so I looked at the history of the cargo manifest file and it looks to me like native-tls was added as a default feature post version 0.11. Did you compile with the --no-default-features flag by chance?

With that being said, these two features shouldn't be getting mixed up. I'll have to adjust that.

Disabling default-features works. Thanks!

sendgrid = { version = "0.13.0", default-features = false, features = ["rustls", "blocking"] }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants