Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using intrinsic-left & intrinsic-top throws an error #166

Open
cbchouinard opened this issue Feb 9, 2015 · 3 comments
Open

Using intrinsic-left & intrinsic-top throws an error #166

cbchouinard opened this issue Feb 9, 2015 · 3 comments
Labels

Comments

@cbchouinard
Copy link
Member

When using:

top: == &[intrinsic-top];
left: == &[intrinsic-left];

I get the following error:
Uncaught Bad initializer to c.Equation

Using x, y works fine:

x: == &[intrinsic-x];
y: == &[intrinsic-y];

I look in the parser and everything seems ok.

@cbchouinard cbchouinard added the bug label Feb 9, 2015
@Inviz
Copy link
Contributor

Inviz commented Feb 10, 2015

Fixed on 2.1.x branch. Though it doesn't de-duplicate intrinsic-top and intrinsic-y, so binding to intrinsic-y may not reset "left" property. It would be a good time to drop x/y properties and move to left/top by default.

@Inviz
Copy link
Contributor

Inviz commented Feb 10, 2015

Per discussion with @d4tocchini we will remove x/y properties and make things be left/top instead. This way only computed-top/intrinsic-top will work and follow logic of computed-height/intrinsic-height.

I also added computed-bottom/computed-height, but computed-size won't work this way. I didnt add intrinsic-bottom/right though, as it's a very dangerous sugar. Do you think we should apply 2d unpacking for size: == intrinsic-size or top-left: == #anchor[computed-right-bottom] to work? Probably there's nothing wrong in hijacking -position, -size, -bottom and -right property suffixes (especially since background-size & background-position work in a similar fashion)

@Inviz
Copy link
Contributor

Inviz commented Feb 17, 2015

Another issue was that using intrinsic-top & intrinsic-left still assigned position: absolute. I fixed that, but I better write more tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants