Skip to content

Commit

Permalink
Fix all dangling commas, Add Sheets API snippets
Browse files Browse the repository at this point in the history
  • Loading branch information
grant committed Jun 29, 2018
1 parent d941321 commit d1241cc
Show file tree
Hide file tree
Showing 29 changed files with 642 additions and 141 deletions.
1 change: 1 addition & 0 deletions .eslintrc.js
Expand Up @@ -7,6 +7,7 @@ module.exports = {
"node": true,
},
"rules": {
"comma-dangle": ["error", "never"],
"max-len": ["error", {"code": 100}],
"camelcase": "off", // Off for destructuring
"async-await/space-after-async": 2,
Expand Down
10 changes: 10 additions & 0 deletions README.md
Expand Up @@ -98,3 +98,13 @@ width="96px"/>

Learn how to clone, pull, and push Apps Script projects on the command line
using [clasp](https://developers.google.com/apps-script/guides/clasp).

## Lint

Run ESLint over this whole repo with:

```
npm run lint
```

This command will fix simple errors.
2 changes: 1 addition & 1 deletion adminSDK/directory/quickstart.gs
Expand Up @@ -21,7 +21,7 @@ function listUsers() {
var optionalArgs = {
customer: 'my_customer',
maxResults: 10,
orderBy: 'email',

This comment has been minimized.

orderBy: 'email'
};
var response = AdminDirectory.Users.list(optionalArgs);

This comment has been minimized.

var users = response.users;
Expand Down
2 changes: 1 addition & 1 deletion adminSDK/reports/quickstart.gs
Expand Up @@ -21,7 +21,7 @@ function listLogins() {
var userKey = 'all';
var applicationName = 'login';
var optionalArgs = {
maxResults: 10,
maxResults: 10
};
var response = AdminReports.Activities.list(userKey, applicationName, optionalArgs);
var activities = response.items;
Expand Down
2 changes: 1 addition & 1 deletion adminSDK/reseller/quickstart.gs
Expand Up @@ -19,7 +19,7 @@
*/
function listSubscriptions() {
var optionalArgs = {
maxResults: 10,
maxResults: 10
};
var response = AdminReseller.Subscriptions.list(optionalArgs);
var subscriptions = response.subscriptions;
Expand Down
2 changes: 1 addition & 1 deletion android/mobile-translate/Code.gs
Expand Up @@ -118,7 +118,7 @@ function getPreferences() {
var userProperties = PropertiesService.getUserProperties();
var languagePrefs = {
originLang: userProperties.getProperty('originLang'),
destLang: userProperties.getProperty('destLang'),
destLang: userProperties.getProperty('destLang')
};
return languagePrefs;
}
Expand Down
2 changes: 1 addition & 1 deletion calendar/quickstart/quickstart.gs
Expand Up @@ -24,7 +24,7 @@ function listUpcomingEvents() {
showDeleted: false,
singleEvents: true,
maxResults: 10,
orderBy: 'startTime',
orderBy: 'startTime'
};
var response = Calendar.Events.list(calendarId, optionalArgs);
var events = response.items;
Expand Down
6 changes: 3 additions & 3 deletions calendar/vacationCalendar/vacationCalendar.gs
Expand Up @@ -54,7 +54,7 @@ function syncTeamVacationCalendar() {
events.forEach(function(event) {
event.summary = '[' + username + '] ' + event.summary;
event.organizer = {
id: TEAM_CALENDAR_ID,
id: TEAM_CALENDAR_ID
};
event.attendees = [];
Logger.log('Importing: %s', event.summary);
Expand Down Expand Up @@ -93,7 +93,7 @@ function findEvents(user, keyword, start, end, opt_since) {
q: keyword,
timeMin: formatDate(start),
timeMax: formatDate(end),
showDeleted: true,
showDeleted: true
};
if (opt_since) {
// This prevents the script from examining events that have not been
Expand Down Expand Up @@ -146,7 +146,7 @@ function getDomainUsers() {
orderBy: 'givenName',
maxResults: 100,
pageToken: pageToken,
viewType: 'domain_public',
viewType: 'domain_public'
});
var users = page.users;
if (users) {
Expand Down
2 changes: 1 addition & 1 deletion classroom/quickstart/quickstart.gs
Expand Up @@ -19,7 +19,7 @@
*/
function listCourses() {
var optionalArgs = {
pageSize: 10,
pageSize: 10
};
var response = Classroom.Courses.list(optionalArgs);
var courses = response.courses;
Expand Down
8 changes: 4 additions & 4 deletions docs/cursorInspector/cursorInspector.gs
Expand Up @@ -55,7 +55,7 @@ function getDocumentInfo() {
element: getElementInfo(cursor.getElement()),
offset: cursor.getOffset(),
surroundingText: cursor.getSurroundingText().getText(),
surroundingTextOffset: cursor.getSurroundingTextOffset(),
surroundingTextOffset: cursor.getSurroundingTextOffset()
};
}
if (selection) {
Expand All @@ -65,9 +65,9 @@ function getDocumentInfo() {
element: getElementInfo(selectedElement.getElement()),
partial: selectedElement.isPartial(),
startOffset: selectedElement.getStartOffset(),
endOffsetInclusive: selectedElement.getEndOffsetInclusive(),
endOffsetInclusive: selectedElement.getEndOffsetInclusive()
};
}),
})
};
}
return result;
Expand All @@ -80,6 +80,6 @@ function getDocumentInfo() {
*/
function getElementInfo(element) {
return {
type: String(element.getType()),
type: String(element.getType())
};
}
4 changes: 2 additions & 2 deletions docs/translate/translate.gs
Expand Up @@ -119,7 +119,7 @@ function getPreferences() {
var userProperties = PropertiesService.getUserProperties();
return {
originLang: userProperties.getProperty('originLang'),
destLang: userProperties.getProperty('destLang'),
destLang: userProperties.getProperty('destLang')
};
}

Expand All @@ -146,7 +146,7 @@ function getTextAndTranslation(origin, dest, savePrefs) {
var text = getSelectedText().join('\n');
return {
text: text,
translation: translateText(text, origin, dest),
translation: translateText(text, origin, dest)
};
}

Expand Down
2 changes: 1 addition & 1 deletion drive/activity/quickstart.gs
Expand Up @@ -21,7 +21,7 @@ function listActivity() {
var optionalArgs = {
'source': 'drive.google.com',
'drive.ancestorId': 'root',
'pageSize': 10,
'pageSize': 10
};
var response = AppsActivity.Activities.list(optionalArgs);
var activities = response.activities;
Expand Down
2 changes: 1 addition & 1 deletion drive/quickstart/quickstart.gs
Expand Up @@ -20,7 +20,7 @@
function listFiles() {
var files = Drive.Files.list({
fields: 'nextPageToken, files(id, name)',
pageSize: 10,
pageSize: 10
}).files;
for (var i = 0; i < files.length; i++) {
var file = files[i];
Expand Down
8 changes: 4 additions & 4 deletions forms/notifications/notification.gs
Expand Up @@ -128,7 +128,7 @@ function getSettings() {
for (var i = 0; i < textItems.length; i++) {
settings.textItems.push({
title: textItems[i].getTitle(),
id: textItems[i].getId(),
id: textItems[i].getId()
});
}
return settings;
Expand Down Expand Up @@ -230,7 +230,7 @@ function sendReauthorizationRequest() {
'Authorization Required',
message.getContent(), {
name: ADDON_TITLE,
htmlBody: message.getContent(),
htmlBody: message.getContent()
});
}
settings.setProperty('lastAuthEmailDate', today);
Expand Down Expand Up @@ -271,7 +271,7 @@ function sendCreatorNotification() {
form.getTitle() + ': Form submissions detected',
message.getContent(), {
name: ADDON_TITLE,
htmlBody: message.getContent(),
htmlBody: message.getContent()
});
}
}
Expand Down Expand Up @@ -300,7 +300,7 @@ function sendRespondentNotification(response) {
settings.getProperty('responseSubject'),
message.getContent(), {
name: form.getTitle(),
htmlBody: message.getContent(),
htmlBody: message.getContent()
});
}
}
Expand Down
4 changes: 2 additions & 2 deletions gmail/add-ons/quickstart.gs
Expand Up @@ -56,14 +56,14 @@ function extractSenderData(messageId) {
'subject': thread.getFirstMessageSubject(),
'count': thread.getMessageCount(),
'link': 'https://mail.google.com/mail/u/0/#inbox/' + thread.getId(),
'lastDate': thread.getLastMessageDate().toDateString(),
'lastDate': thread.getLastMessageDate().toDateString()
});
}
});

var senderData = {
email: senderEmail,
recents: recents,
recents: recents
};

return senderData;
Expand Down
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -20,7 +20,7 @@
"eslint-plugin-async-await": "0.0.0"
},
"scripts": {
"lint": "./node_modules/.bin/eslint **/**/*.gs --fix"
"lint": "./node_modules/.bin/eslint **/**/*.gs --fix --quiet"
},
"eslintIgnore": [
"**/node_modules/**"
Expand Down
44 changes: 44 additions & 0 deletions sheets/api/helpers.gs
@@ -0,0 +1,44 @@
var filesToDelete = [];
/**
* Helper methods for Google Sheets tests.
*/
function Helpers() {
this.filesToDelete = [];
}

Helpers.prototype.reset = function() {
this.filesToDelete = [];
};

Helpers.prototype.deleteFileOnCleanup = function(id) {
this.filesToDelete.push(id);
};

Helpers.prototype.cleanup = function() {
filesToDelete.forEach(Drive.Files.remove);
};

Helpers.prototype.createTestSpreadsheet = function() {
var spreadsheet = SpreadsheetApp.create('Test Spreadsheet');
for (var i = 0; i < 3; ++i) {
spreadsheet.appendRow([1, 2, 3]);
}
this.deleteFileOnCleanup(spreadsheet.getId());
return spreadsheet.getId();
};

Helpers.prototype.populateValues = function(spreadsheetId) {
var batchUpdateRequest = Sheets.newBatchUpdateSpreadsheetRequest();
var repeatCellRequest = Sheets.newRepeatCellRequest();

var values = [];
for (var i = 0; i < 10; ++i) {
values[i] = [];
for (var j = 0; j < 10; ++j) {
values[i].push('Hello');
}
}
var range = 'A1:J10';
SpreadsheetApp.openById(spreadsheetId).getRange(range).setValues(values);
SpreadsheetApp.flush();
};

1 comment on commit d1241cc

@deadman828
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how to do pls hulp

Please sign in to comment.