Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moodle 3.10 and 3.9 support #39

Open
cameron1729 opened this issue Mar 23, 2022 · 1 comment
Open

Moodle 3.10 and 3.9 support #39

cameron1729 opened this issue Mar 23, 2022 · 1 comment

Comments

@cameron1729
Copy link
Contributor

The new work done in the master branch prevents unit tests from working in Moodle 3.9 and 3.10. Moodle 3.11 onwards is using PHPUnit 9, which has a different function for asserting regular expression matches.

Based on the existing branches in this repo, it looks like we should backport the duplicate detection and refactoring work to the MOODLE_39_STABLE branch, but not update the unit tests to use assertMatchesRegularExpression.
@cameron1729 cameron1729 mentioned this issue Mar 23, 2022
Merged
@cameron1729
Copy link
Contributor Author

@gthomas2 can you please check this is all OK?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cameron1729