fix: update location memory bug and remove default values

gtokman · May 6, 2021 · 764be27 · 764be27
1 parent c2cc1ac
commit 764be27
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/Sources/ExtensionKit/CoreLocation/AuthorizationPublisher.swift b/Sources/ExtensionKit/CoreLocation/AuthorizationPublisher.swift
@@ -57,7 +57,7 @@ final class AuthorizationPublisher: NSObject,
 
     private let manager: CLLocationManager
     private let authorizationType: CLLocationManager.AuthorizationType
-    private weak var publisherAuthorizationDelegate: PublisherAuthorizationDelegate?
+    private var publisherAuthorizationDelegate: PublisherAuthorizationDelegate?
 
     init(manager: CLLocationManager, authorizationType: CLLocationManager.AuthorizationType) {
         self.manager = manager

diff --git a/Sources/ExtensionKit/CoreLocation/CLLocationManager.swift b/Sources/ExtensionKit/CoreLocation/CLLocationManager.swift
@@ -9,7 +9,7 @@ public extension CLLocationManager {
     ///   - type: `AuthorizationType`
     /// - Returns: Publisher with `AuthorizationType`
     static func requestLocationAuthorization(
-        with manager: CLLocationManager = .init(),
+        with manager: CLLocationManager
         type: AuthorizationType
     ) -> AnyPublisher<CLAuthorizationStatus, Never> {
         AuthorizationPublisher(manager: manager, authorizationType: type)
@@ -21,7 +21,7 @@ public extension CLLocationManager {
     ///   - manager: `CLLocationManager`
     /// - Returns: Publisher with `AuthorizationType`
     static func requestLocationAlwaysAuthorization(
-        with manager: CLLocationManager = .init()
+        with manager: CLLocationManager
     ) -> AnyPublisher<CLAuthorizationStatus, Never> {
         AuthorizationPublisher(manager: manager, authorizationType: .always)
             .flatMap { status -> AnyPublisher<CLAuthorizationStatus, Never> in
@@ -41,7 +41,7 @@ public extension CLLocationManager {
     /// - Parameter manager: `CLLocationManager`
     /// - Returns: Publisher with `[CLLocation]` or `Error`
     static func receiveLocationUpdates(
-        from manager: CLLocationManager = .init()
+        from manager: CLLocationManager
     ) -> AnyPublisher<[CLLocation], Error> {
         LocationPublisher(manager: manager)
             .eraseToAnyPublisher()

diff --git a/Sources/ExtensionKit/CoreLocation/LocationPublisher.swift b/Sources/ExtensionKit/CoreLocation/LocationPublisher.swift
@@ -51,7 +51,7 @@ final class LocationPublisher: NSObject,
     typealias Failure = Error
 
     private let manager: CLLocationManager
-    private weak var subscriberDelegate: SubscriptionLocationDelegate?
+    private var subscriberDelegate: SubscriptionLocationDelegate?
 
     init(manager: CLLocationManager) {
         self.manager = manager