Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify defaults for variables #49

Open
dkastl opened this issue Oct 15, 2021 · 4 comments
Open

Specify defaults for variables #49

dkastl opened this issue Oct 15, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@dkastl
Copy link
Member

dkastl commented Oct 15, 2021

Currently it seems to be required to have an .env in place with environment variables set.

WARN[0000] The "GEM_PG_VERSION" variable is not set. Defaulting to a blank string. 
WARN[0000] The "SMTP_PASSWORD" variable is not set. Defaulting to a blank string. 
WARN[0000] The "SMTP_AUTHENTICATION" variable is not set. Defaulting to a blank string. 
WARN[0000] The "GEM_PG_VERSION" variable is not set. Defaulting to a blank string. 
WARN[0000] The "SMTP_ADDRESS" variable is not set. Defaulting to a blank string. 
WARN[0000] The "SMTP_PORT" variable is not set. Defaulting to a blank string. 
WARN[0000] The "POSTGRES_PASSWORD" variable is not set. Defaulting to a blank string. 
WARN[0000] The "POSTGRES_USER" variable is not set. Defaulting to a blank string. 
WARN[0000] The "POSTGRES_DB" variable is not set. Defaulting to a blank string. 
WARN[0000] The "SMTP_DOMAIN" variable is not set. Defaulting to a blank string. 
WARN[0000] The "SMTP_USER_NAME" variable is not set. Defaulting to a blank string. 
WARN[0000] The "SMTP_ENABLE_STARTTLS_AUTO" variable is not set. Defaulting to a blank string. 
WARN[0000] The "POSTGRES_USER" variable is not set. Defaulting to a blank string. 
WARN[0000] The "POSTGRES_PASSWORD" variable is not set. Defaulting to a blank string. 
WARN[0000] The "POSTGRES_DB" variable is not set. Defaulting to a blank string. 

If possible, it might be nice to have a default value for each variable.

@dkastl dkastl added enhancement New feature or request question Further information is requested labels Oct 15, 2021
@sanak
Copy link
Member

sanak commented Oct 15, 2021

@dkastl I added .env.example for the default value and mentioned it on README.md - Quick start section.

@dkastl
Copy link
Member Author

dkastl commented Oct 15, 2021

Yes, I know this. I just saw also this line https://github.com/gtt-project/docker-gtt/blob/main/Dockerfile#L74
And it's also specified in .env. So maybe we could have fallback values if not set in .env

@sanak
Copy link
Member

sanak commented Oct 15, 2021

Okay, but I guess that .env variables may be increased for future, so duplicating both side may cost.

@dkastl
Copy link
Member Author

dkastl commented Oct 15, 2021

Not sure if there would be a way to have another default.env file and values are taken from there when not provided by .env. But just an idea.

@sanak sanak self-assigned this May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants