Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature - ent] See if 32-bit support is possible #1206

Open
jeffmendoza opened this issue Aug 30, 2023 · 2 comments
Open

[feature - ent] See if 32-bit support is possible #1206

jeffmendoza opened this issue Aug 30, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@jeffmendoza
Copy link
Collaborator

jeffmendoza commented Aug 30, 2023

ent/ent#3125 Implies that the ent folks know they don't compile on 32-bit, and are not concerned (Asking about use case), but the issue is open, they maybe would accept a pr? Looks like just some casting is needed around bit shifts. The line we are getting is https://github.com/ent/contrib/blob/v0.4.5/entgql/template/node.tmpl#L271 in particular, but sounds like there are multiple of these in ent.

Looking at #910 (comment) Is there a workaround for this? different ID types? If so, we may want to do that. If not, let's discuss further if we want to pick this up with ent.

@lumjjb
Copy link
Contributor

lumjjb commented Sep 5, 2023

Based on looking at https://github.com/droyo/styx/pull/17/files, would this be an upstream fix to ent to change that to uint32?

@lumjjb
Copy link
Contributor

lumjjb commented Sep 5, 2023

Also , would we be able to skip building ent for 32 bit if we use build constraints? https://pkg.go.dev/go/build#hdr-Build_Constraints

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants