Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve BPM fix by interpolating in the dispersion axis #262

Closed
sergiopasra opened this issue Jul 24, 2019 · 0 comments
Closed

Improve BPM fix by interpolating in the dispersion axis #262

sergiopasra opened this issue Jul 24, 2019 · 0 comments
Assignees

Comments

@sergiopasra
Copy link
Member

sergiopasra commented Jul 24, 2019

By default BPM correction is computed as the median of valid pixels in a 5x5 box. In MEGARA, this approach mixes bright pixels from the peak of the fibers with dark values from the valley between fibers. In my tests, I get better results if the box contains values only in the X direction (like 7x1)

@sergiopasra sergiopasra added this to the MEGARA DRP v0.10 milestone Jul 24, 2019
@sergiopasra sergiopasra self-assigned this Jul 24, 2019
@sergiopasra sergiopasra changed the title Improve BPM fix by interpolating in X direction Improve BPM fix by interpolating in dispersion axis Jul 24, 2019
@sergiopasra sergiopasra changed the title Improve BPM fix by interpolating in dispersion axis Improve BPM fix by interpolating in the dispersion axis Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant