Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_cube_from_rss returns nans for flux and velocity map #279

Open
amanda-olmo opened this issue Mar 3, 2020 · 4 comments
Open

create_cube_from_rss returns nans for flux and velocity map #279

amanda-olmo opened this issue Mar 3, 2020 · 4 comments
Assignees
Labels

Comments

@amanda-olmo
Copy link

While trying to draw contours with visualization, I have found that create_cube_from_rss returns a cube full of nans (line 421 in visualization). This happens when the contours are to be taken from the flux or velocity column. It does not happen when the continuum column is selected.

python -m megaradrp.visualization mrk324_f2_ha.fits --contour --contour-image mrk324_f2_ha.fits --contour-image-column 17 -c 2 --hex-rel-size 1.26
world coordinates in pixel
use column 2
world coordinates in pixel
use column 17
fiber coordinates in arcsec
fiber coordinates in arcsec
Estoy aqui
WARNING: FITSFixedWarning: CUNIT3 = / Units of coordinate increment and value
a string value was expected. [astropy.wcs.wcs]
/Users/root2/opt/anaconda3/envs/megaradev/lib/python3.7/site-packages/matplotlib/contour.py:1520: UserWarning: Warning: converting a masked element to nan.
self.zmax = float(z.max())
/Users/root2/opt/anaconda3/envs/megaradev/lib/python3.7/site-packages/matplotlib/contour.py:1521: UserWarning: Warning: converting a masked element to nan.
self.zmin = float(z.min())
/Users/root2/opt/anaconda3/envs/megaradev/lib/python3.7/site-packages/matplotlib/contour.py:1169: RuntimeWarning: invalid value encountered in less
under = np.nonzero(lev < self.zmin)[0]
/Users/root2/opt/anaconda3/envs/megaradev/lib/python3.7/site-packages/matplotlib/contour.py:1171: RuntimeWarning: invalid value encountered in greater
over = np.nonzero(lev > self.zmax)[0]
/Users/root2/opt/anaconda3/envs/megaradev/lib/python3.7/site-packages/matplotlib/contour.py:1200: RuntimeWarning: invalid value encountered in greater
inside = (self.levels > self.zmin) & (self.levels < self.zmax)
/Users/root2/opt/anaconda3/envs/megaradev/lib/python3.7/site-packages/matplotlib/contour.py:1200: RuntimeWarning: invalid value encountered in less
inside = (self.levels > self.zmin) & (self.levels < self.zmax)
/Users/root2/opt/anaconda3/envs/megaradev/lib/python3.7/site-packages/megaradrp-0.10.dev0-py3.7.egg/megaradrp/visualization.py:423: UserWarning: No contour levels were found within the data range.
mm = ax.contour(interp, transform=tt_d)
contour levels [nan]

@sergiopasra sergiopasra self-assigned this Mar 20, 2020
@sergiopasra
Copy link
Member

@amanda-olmo Could you send me the image? Thanks

@sergiopasra
Copy link
Member

@amanda-olmo Amanda, the image itself has nan values. Cube doesn't mask or handle specially nan values as they are not expected to appear. nan values usually spoil all the math operations unless handled specially. This means that if you image has nan values, the contours will be nan also.

My question is, the nan values represent something, missing data for example, or are they simply the result of a bad math operation, like 0 / 0? If it is the later, then this is not a bug

@amanda-olmo
Copy link
Author

The input file for the contours (mrk324_f2_ha.fits) is the output of the program analyse_rss.py which performs a fitting of the emission lines. In order to do the fit in a spaxel, the line must be above a certain signal to noise ratio. If the fit is not done, the program outputs a nan in almost every channel for that spaxel. So, the nan values represent missing data.

I am not working with visualization.py anymore. I am using visualization_mine.py from Armando. The input of the program is the same as visualization.py, but it does not have this problem with the nan values. It can draw the contours.

@sergiopasra
Copy link
Member

Well, I can review the solution in @gildepaz program and see if it is feasible to use it in visualization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants