Changed some conditions and loops to positive statements #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,7 +25,7 @@ module Guard | |||
|
|
|||
| def self.usable? | |||
| require 'rb-fsevent' | |||
| if !defined?(FSEvent::VERSION) || Gem::Version.new(FSEvent::VERSION) < Gem::Version.new('0.3.9') | |||
| unless defined?(FSEvent::VERSION) || Gem::Version.new(FSEvent::VERSION) >= Gem::Version.new('0.3.9') | |||
There was a problem hiding this comment.
I think (!a || b) == !(a && !b) but you wrote !(a || !b). Anyway, we try to always avoid multiple conditions with "unless".
|
Thanks for your interest in Guard, I think we will not merge the "unless" with multiple conditions since it's less clear than before (moreover, the conditions appears to be wrong to me now), but we could definitely merge the "until"! ;) Bed time now here! |
|
I just reverted the unless with multiple conditions. It got a little weird, I admit. I'll see what else I can help (: Bed time here also. |
rymai
pushed a commit
that referenced
this pull request
May 6, 2011
Changed some loops to positive statements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really liked the gem and wanted to help as I can