show inotify limit error *before* calling abort #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Celluloid catches abort(SystemExit) and shuts down the supervisor group without displaying the abort message.
|
I think this deserves merging and releasing above everything else, because lots of Linux users will be upgrading with potentially having the inotify limits reset and ... getting NO warning (!). That's because celluloid catches the failing adapter's abort and ignores the message - which is never shown. |
This was referenced Apr 25, 2014
|
Good catch! |
thibaudgg
added a commit
that referenced
this pull request
Apr 25, 2014
show inotify limit error *before* calling abort
|
2.7.2 released, https://github.com/guard/listen/releases |
|
It seems to have some "uninitialized constant INotify" errors on travis randomly: https://travis-ci.org/guard/listen/jobs/23731057#L568 |
|
My mistake - I pushed the fix directly to master (fixed broken spec - travis should work now consistently). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Celluloid catches abort(SystemExit) and shuts down the supervisor group
without displaying the abort message.