New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependency with gems that are not required #553

Open

tamiradari opened this issue Apr 5, 2022 · 1 comment

tamiradari commented Apr 5, 2022

Both rb-fsevent and rb-inotify are in the dependency in listen-3.7.1.gemspec.
But:

For Linux only rb-inotify is required.
For Darwin (OSX) only rb-fsevent is required.
For Windows, none of them is required (WDM can be added).

tamiradari changed the title ~~dependency for gems that are not required~~ dependency with gems that are not required

Poitrin mentioned this issue

Add 'wdm' to bundled CLI 2.x Gemfile Shopify/cli#814

Merged

4 tasks

Collaborator

ColinDKelley commented Nov 28, 2022

@tamiradari These are good points.

Could you possibly submit a PR that makes these dependencies conditional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment