Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require eslint disable explanation #42

Merged
merged 4 commits into from Oct 12, 2020
Merged

Require eslint disable explanation #42

merged 4 commits into from Oct 12, 2020

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented Oct 8, 2020

What does this change?

  • lints for explanations if you eslint-disable

Why?

info for the next viewer

@sndrs sndrs requested a review from a team as a code owner October 8, 2020 12:23
mxdvl
mxdvl reviewed Oct 8, 2020
View reviewed changes
Copy link
Member

@mxdvl mxdvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

jest.config.js Outdated Show resolved Hide resolved
@sndrs @mxdvl
Update jest.config.js
d1fddeb 
Co-authored-by: Max Duval <max.duval@guardian.co.uk>
@sndrs sndrs merged commit dcc8f24 into main Oct 12, 2020
@sndrs sndrs deleted the require-eslint-disable-comments branch October 12, 2020 11:03
@sndrs
Copy link
Member Author

sndrs commented Oct 12, 2020

🎉 This PR is included in version 0.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sndrs sndrs added the released label Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxdvl mxdvl mxdvl left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sndrs @mxdvl