Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: @guardian/commercial peer dependency mismatch #10204

Closed
Tracked by #6945
mxdvl opened this issue Jan 15, 2024 · 3 comments · Fixed by #10324
Closed
Tracked by #6945

[Bug]: @guardian/commercial peer dependency mismatch #10204

mxdvl opened this issue Jan 15, 2024 · 3 comments · Fixed by #10324
Assignees
Labels
Dependencies Pull requests that update a dependency file
Milestone

Comments

@mxdvl
Copy link
Member

mxdvl commented Jan 15, 2024

What happened?

There are a number of peer dependency mismatches in DCR for @guardian/commercial. Excerpt from pnpm i --resolution-only:

#
├─┬ @guardian/commercial 11.32.1
│ ├── ✕ unmet peer @guardian/libs@^15.6.4: found 16.0.0
│ ├── ✕ unmet peer @guardian/source-foundations@^13.0.0: found 14.1.2
│ ├── ✕ unmet peer @guardian/ab-core@^5.0.0: found 7.0.1
│ ├── ✕ unmet peer @guardian/core-web-vitals@^5.1.0: found 6.0.0
│ └─┬ prebid.js 8.24.0
│   └─┬ @guardian/libs 15.7.1
│     └── ✕ unmet peer typescript@~5.1.3: found 5.3.3
#

Tip

You can check this yourself by running pnpm install --resolution-only

@guardian/commercial-dev please could you update this package to use versions that are compatible with this repo?

What is the impact?

This will soon become a blocker as we want to enforce met peer dependencies in this repo

@mxdvl mxdvl added Rota Any issues that have come in as part of rota. Useful for the person on rota to track their work. Dependencies Pull requests that update a dependency file labels Jan 15, 2024
@mxdvl mxdvl changed the title [Bug]: @guardian/commercial [Bug]: @guardian/commercial peer dependency mismatch Jan 15, 2024
@mxdvl mxdvl added this to the Health milestone Jan 15, 2024
@cemms1 cemms1 removed the Rota Any issues that have come in as part of rota. Useful for the person on rota to track their work. label Jan 15, 2024
@Jakeii
Copy link
Member

Jakeii commented Jan 15, 2024

Noted, will get this sorted out!

@i-hardy
Copy link
Contributor

i-hardy commented Jan 17, 2024

We'll be tackling the prebid dependency separately; the others should be fixed by guardian/frontend#26819 and #10243

@cemms1
Copy link
Contributor

cemms1 commented Jan 17, 2024

Thanks @i-hardy, that's great! ✨ Will leave this ticket open until the prebid dep is sorted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants