Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Star ratings are missing from onward journey carousels #11465

Closed
abeddow91 opened this issue May 22, 2024 · 3 comments · Fixed by #11540
Closed

Star ratings are missing from onward journey carousels #11465

abeddow91 opened this issue May 22, 2024 · 3 comments · Fixed by #11540
Assignees
@abeddow91
Labels
Rota Any issues that have come in as part of rota. Useful for the person on rota to track their work.
Milestone
Requests

Comments

@abeddow91
Copy link
Contributor

Star ratings are missing from onward journey carousels. This might be an intentional design decision. If it was not, then these must have been missed in the migration and should be added back as per designs.
@abeddow91 abeddow91 added the Rota Any issues that have come in as part of rota. Useful for the person on rota to track their work. label May 22, 2024
@abeddow91 abeddow91 added this to the Requests milestone May 22, 2024
@abeddow91
Copy link
Contributor Author

@HarryFischer has been messaged about this to find out if these should appear or not.

@mxdvl
Copy link
Member

mxdvl commented Jun 4, 2024 •
edited

Awaiting on Figma designs

@HarryFischer
Copy link
Contributor

Can we just copy what we do on Fronts? Sizing should be the same. I won't have time to supply designs before Elections are over

@abeddow91 abeddow91 self-assigned this Jun 5, 2024
@abeddow91 abeddow91 linked a pull request Jun 5, 2024 that will close this issue
Pass star rating to carousel cards #11540
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abeddow91 abeddow91

Labels
Rota Any issues that have come in as part of rota. Useful for the person on rota to track their work.
Projects
WebX Team
Status: Done
Milestone
Requests
Development

Successfully merging a pull request may close this issue.

Pass star rating to carousel cards guardian/dotcom-rendering
3 participants
@mxdvl @abeddow91 @HarryFischer