Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve efficiency of context in islands code #8795

Open
cemms1 opened this issue Sep 8, 2023 · 0 comments
Open

Improve efficiency of context in islands code #8795

cemms1 opened this issue Sep 8, 2023 · 0 comments
Milestone

Comments

@cemms1
Copy link
Contributor

cemms1 commented Sep 8, 2023

In the PR to trial using React context for renderingTarget #8704, suggestions to improve the efficiency of the islands code were made, which should be looked into.

The same config value is being provided to all islands in a rendering request, when a more efficient way to do this might be to share this in a more common place (rather than props for each island) since the data will be the same for each request.

Summary of thread here:

You could serialise with JSON.stringify inside a single script tag with type application/json on the page?

Originally posted by @mxdvl in #8704 (comment)

To @mxdvl's suggestion here's an example I came across recently of using the script tag in apps-rendering

Originally posted by @ioannakok in #8704 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant