Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The difference between ignoredMarks and skippedMarks isn't clear #197

Open
jonathonherbert opened this issue Feb 28, 2022 · 0 comments
Open

The difference between ignoredMarks and skippedMarks isn't clear #197

jonathonherbert opened this issue Feb 28, 2022 · 0 comments
Labels
naming A problem with naming conventions – clarity, consistency, etc.

Comments

@jonathonherbert
Copy link
Contributor

The difference between ignoredMarks and skippedMarks, callbacks provided in the public API, isn't clear:

  • ignoredMarks is a function that, given a node, returns ranges that invalidate suggestions returned from typerighter.
  • skippedMarks is a function that, given a node, returns ranges that are never sent to Typerighter (the text is never visible to the checker.)

What might be a better name for these functions?
@jonathonherbert jonathonherbert added the naming A problem with naming conventions – clarity, consistency, etc. label Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
naming A problem with naming conventions – clarity, consistency, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonathonherbert